-
Notifications
You must be signed in to change notification settings - Fork 9
Set the default domain when provided #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KyleJ61782
wants to merge
13
commits into
horar:master
Choose a base branch
from
KyleJ61782:SetDefaultDomain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
This will help to identify the banner message in other tools. Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
By establishing the route prior to interface configuration we avoid traffic loops. Report and fix by Niels Peen. Resolves horar#5 Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
2. Added REDIRECT_GATEWAY_METHOD = -1 mode, which leaves default route intact, but do all other necessary route setup. This mode can be used by advanced users who already have the persistent route set up. For example, only certain IP/subnet will to through VPN, while all other traffic still go through native interface (improves latency for, i.e. Google search) Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
… error codes fixed. Small re-indentation and re-wrap as well. Based on many commits from openconnect-gui project. Thanks. Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
Based on suggestion in github/openconnect/openconnect-gui#125 Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
Don't preset variable. Just expand on right place as other ones. Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
It's just a number. The quotation marks make sense for previous version of script with interface names (which contains white chars). Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
New version introduce issues for some users. Later, this option will be configurable via GUI Signed-off-by: Ľubomír Carik <Lubomir.Carik@gmail.com>
7dbb613 to
db2477b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the default DNS search domain when provided by the server. It utilizes WMIC because it's the most compatible command line method to adjust the default DNS search domain (NETSH doesn't have this capability for some strange reason).