Skip to content

Conversation

@fsylum
Copy link

@fsylum fsylum commented Mar 21, 2024

This PR will add additional verification methods to the Postmark provider.

Summary of changes:

  • README update with Configuration section.
  • Two new verification methods added.
  • Added related test cases.

Fixes #7.

Please let me know what you think, thanks!

@hotmeteor
Copy link
Owner

@fsylum Thanks for your contribution! I think this is great.

My only blocker on this is the config. I've tried to make it so that Receiver uses the existing services.php config, just like the "Notifications" feature, or packages like Socialite.

So what I'd prefer is for it not to include a new config file but to instead look for these values in services.postmark. Then we should add some provider-specific configuration settings to the documentation.

Hope that makes sense!

@fsylum
Copy link
Author

fsylum commented May 5, 2024

Thanks @hotmeteor for the feedbacks!

I've removed the custom config file and updated the documentation section for the Configuration part.

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authenticate postmark webhooks by IP

2 participants