Add tokei #43
Add tokei #43
Conversation
Dockerfile
Outdated
| COPY analytics/pnpm-lock.yaml . | ||
| COPY analytics/tsconfig.json . | ||
| RUN mkdir /metrics | ||
| VOLUME ["/metrics"] |
There was a problem hiding this comment.
Why is an anonymous volume beneficial here?
There was a problem hiding this comment.
Its not for now, removed it
| export default function MetricsPage() { | ||
| const { owner, repo, commitSHA, branch } = useParams(); | ||
|
|
||
| console.log(owner, repo, commitSHA, branch); |
There was a problem hiding this comment.
Remove or comment out debugging information?
frontend/src/utils/github.ts
Outdated
| files: string[] = ["metrics.json"] | ||
| ): Promise<MetricsBlob[]> { | ||
| const ref_string = `metrics/${commit_sha}`; | ||
| console.log(ref_string); |
There was a problem hiding this comment.
Remove or comment out debugging information?
Dockerfile
Outdated
|
|
||
| RUN curl -vL --compressed https://github.com/XAMPPRocky/tokei/releases/download/v12.1.2/tokei-x86_64-unknown-linux-gnu.tar.gz --output tokei.tar.gz | ||
| RUN tar -xvf tokei.tar.gz | ||
| RUN ./tokei /repository --output json > /metrics/metrics.json |
There was a problem hiding this comment.
For me, it's not clear how this run of tokei will result in a software project being analyzed.
There was a problem hiding this comment.
As we run a checkout action before running our action we will have copied the whole repository to be analysed into our own action Docker container under /repository at build time. we then also just compute metrics into a json at build time and use this file as an artifact to upload as a blob to the git refs and decode and use in the frontend.
This is arguably not the best solution as it does not allow for caching and reusing the image built for this action. Maybe we can get around this issue by mounting a volume instead in the future.
|
Looks good to me. Nice updating of the dependencies even across major versions. |
This PR add tokei as the main analytics tool and changes the frontend metrics format from csv to json