Skip to content

Conversation

@NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Nov 20, 2025

Prepares us for test extraction

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/test-app-boilerplate branch from 2937c00 to c0ec8a1 Compare November 20, 2025 23:52
@NullVoxPopuli NullVoxPopuli merged commit 1846c99 into main Nov 21, 2025
22 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/test-app-boilerplate branch November 21, 2025 16:06
@github-actions github-actions bot mentioned this pull request Nov 10, 2025
@mixonic
Copy link
Contributor

mixonic commented Jan 2, 2026

@NullVoxPopuli the Old tests now seem to be failing, as at https://github.com/html-next/vertical-collection/actions/runs/20665370617/job/59336392129?pr=505.

Do the Old tests remain valid at this point, and they need to pass? This PR didn't really explain how to think about the tests flagged Old.

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Jan 2, 2026

They are still valid, as the tests haven't changed from back when this repo was a 1-package v1 addon / non-monoerpo -- the old paths and dummy app usage remain.

Last I checked, they were still passing.

The next step of converting to a v2 addon is to move the tests to a test-app (in part for assuring the dependencies are correct).

However, every time I try to move components into normal paths in their own app, I fail, e.g.: #490.

the Old tests now seem to be failing, as at https://github.com/html-next/vertical-collection/actions/runs/20665370617/job/59336392129?pr=505.

it looks like @ember/test-waiters is missing is all -- probably caused by a floating dep problem -- specific to that webpack upgrade PR -- for example, this other run passes: https://github.com/html-next/vertical-collection/actions/runs/20665111362

The path forward here is likely for someone to finish the test-app extraction, so we can quit using a dummy app (dummy apps are madness and make no sense)

@mixonic
Copy link
Contributor

mixonic commented Jan 2, 2026

Ok, so they are "old" as in they use the test-app, which is considered an older approach to testing. But they remain valid.

Thank you!

@NullVoxPopuli
Copy link
Contributor Author

Ok, so they are "old" as in they use the test-app,

yea, the "new" CI jobs are actually empty, because the migration work hasn't been finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants