Fix occluded-content height inflation from inherited line-height #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When occluded-content is rendered inside a table (display: table-row),
the debug text ("And X items before/after") can create a line box that
inflates the element's actual height above its inline style height.
This causes VerticalCollection to measure the wrong height and adjust
its estimates, leading to visual jumps when scrolling.
Add font-size: 0 and line-height: 0 to prevent the text from affecting
layout while keeping it available for screen readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
occluded-contentheight could be inflated by inheritedline-heightwhen used inside tables, causing visual jumps during scrolling.Problem
When using VerticalCollection inside a
<table>:occluded-contentelement renders asdisplay: table-rowline-heightset (e.g., from Tailwind or global styles), this text creates a line boxgetBoundingClientRect().height) becomes larger than the inlinestyle="height: 44px"Solution
Add
font-size: 0andline-height: 0to.occluded-contentCSS, ensuring the debug text cannot affect layout height.Test plan
line-height: 0is set on occluded-contentBefore fix:
not ok 1 - occluded-content should have line-height: 0
expected: 0px
actual: 20px
After fix:
ok 1 - occluded-content should have line-height: 0