feat / Add defaultNetworks parameter to chain configs #583
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds optional defaultNetworks array to Solana and Ethereum chain configs to allow specifying which networks to query for balance operations. This optimizes performance by avoiding queries to all 9+ networks when only 1-2 are needed. Changes: - Add defaultNetworks to chain schemas with additionalProperties: true for backwards compatibility - Add defaultNetworks to SolanaChainConfig and EthereumChainConfig interfaces - Update config getter functions to include defaultNetworks - Add commented examples in template files Closes #581 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rapcmia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional
defaultNetworksarray to Solana and Ethereum chain configs to allow specifying which networks to query for balance operations. This optimizes performance by avoiding queries to all 9+ networks when only 1-2 are needed.Closes #581
Changes
defaultNetworksto chain schemas (solana-chain-schema.json,ethereum-chain-schema.json)additionalProperties: truefor backwards compatibilitydefaultNetworks?: string[]toSolanaChainConfigandEthereumChainConfiginterfacesdefaultNetworkssolana.yml,ethereum.yml)Configuration Example
Backwards Compatibility
defaultNetworksis optional - if not specified, behavior is unchangedadditionalProperties: trueensures existing configs work without modificationdefaultNetworkremains the primary config for single-network operationsTest plan
/config?namespace=ethereumreturnsdefaultNetworksfielddefaultNetworksstill work🤖 Generated with Claude Code