Skip to content

Reset MSRs when restoring snapshot #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ludfjig wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reset MSRs when restoring snapshot #991

ludfjig wants to merge 2 commits into from

Conversation

@ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Oct 27, 2025 •
edited
Loading

Requires #517, will mark ready when it's merged. For now only the last commit is relevant.

TODO:

  • Wait for KVM PR to merge
  • Change to safe kvm binding version
  • Think harder about kvm_debug_regs vs kvm_debug_regs_arch

@ludfjig ludfjig force-pushed the reset2 branch 7 times, most recently from aeca04d to 968f2f4 Compare October 31, 2025 00:29
@ludfjig ludfjig added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Dec 2, 2025
@ludfjig ludfjig force-pushed the reset2 branch 2 times, most recently from e536d57 to e859ff9 Compare December 8, 2025 18:22
@ludfjig
Implement debug register abstraction
429446f 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Reset more vcpu state after snapshot::restore
e793129 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig changed the title Reset more state when restoring snapshot Reset MSRs when restoring snapshot Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbugs danbugs Awaiting requested review from danbugs danbugs will be requested when the pull request is marked ready for review danbugs is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz will be requested when the pull request is marked ready for review dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned will be requested when the pull request is marked ready for review devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically will be requested when the pull request is marked ready for review syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset will be requested when the pull request is marked ready for review marosset is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes will be requested when the pull request is marked ready for review jprendes is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies will be requested when the pull request is marked ready for review simongdavies is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ludfjig