fix: exception swallowing in Redis::__call()
#315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation had a bug where exceptions thrown during Redis command execution were silently swallowed when: 1. A context connection existed (hasContextConnection=true) 2. The command required same-connection handling (multi/pipeline/select) This happened because `return` statements inside a `finally` block override any pending exception from the `catch` block. Changes: - Restructure try/catch/finally to capture exception without immediate re-throw - Move exception re-throw to after finally block completes - On error with same-connection commands: release connection instead of storing (a failed multi/pipeline/select has nothing to continue, storing would be wrong) - Add comprehensive test coverage for exception propagation and connection release logic across all scenarios The connection release behavior is now: - Success + context connection: don't release (managed by context) - Success + same-connection cmd: store in context, release via defer() - Success + normal cmd: release immediately - Error + context connection: don't release, propagate exception - Error + same-connection cmd: release immediately, propagate exception - Error + normal cmd: release immediately, propagate exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This bug was found by by PHPStan at level 5
The previous implementation had a bug where exceptions thrown during
Rediscommand execution were silently swallowed when:This happened because
returnstatements inside afinallyblock override any pending exception from thecatchblock.Changes: