fix: pathsToPublish returning empty array instead of all paths #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pathsToPublish() is called with no arguments, it should return all published paths from all providers. Instead, it was returning an empty array. The bug: pathsForProviderOrGroup() always returned [] at the end, even when no filter was specified. The calling code checks for null to determine whether to fall back to returning all paths. The fix: Return null when no filter is specified (both $provider and $group are null), and return [] only when a filter was specified but not found. This matches Laravel's behavior. Added tests for: - pathsToPublish() with no args returns all paths - pathsToPublish() with non-existent provider returns [] - pathsToPublish() with non-existent group returns []
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This bug was found by PHPStan at level 5
When
pathsToPublish()is called with no arguments, it should return all published paths from all providers. Instead, it was returning an empty array.The bug:
pathsForProviderOrGroup()always returned[]at the end, even when no filter was specified. The calling code checks for null to determine whether to fall back to returning all paths.The fix: Return null when no filter is specified (both $provider and $group are null), and return [] only when a filter was specified but not found. This matches Laravel's behavior.
Added tests for: