fix: operator precedence bugs and PSR-7 getHeader usage #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilesystemManager: Fix operator precedence in read-only check - `?? false === true` was parsed as `?? (false === true)` - Now correctly checks `($config['read-only'] ?? false) === true` StartSession: Fix operator precedence in AJAX detection - `! header(...) === 'X'` was parsed as `(! header(...)) === 'X'` - Boolean === string is always false, so storeCurrentUrl never worked - Now correctly checks `header(...) !== 'XMLHttpRequest'` TestResponseAssert: Fix PSR-7 getHeader returns array not string - `getHeader()` returns string[], not string - Array === string is always false, so JSON error injection never worked - Now correctly uses `getHeader(...)[0] ?? ''` with str_contains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: These bugs were found by PHPStan at level 5
FilesystemManager: Fix operator precedence in read-only check
?? false === truewas parsed as?? (false === true)($config['read-only'] ?? false) === trueStartSession: Fix operator precedence in AJAX detection
! header(...) === 'X'was parsed as(! header(...)) === 'X'header(...) !== 'XMLHttpRequest'TestResponseAssert: Fix PSR-7 getHeader returns array not string
getHeader()returns string[], not stringgetHeader(...)[0] ?? ''with str_contains