ENH: Add 2018 lookup default parameters to YML file #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
baseline_2018andHupkes_2018parameters to thedefault_params.yml.baseline_2018uses the baseline parameters stored in machine-task found by Hupkes et al. 2018, whileHupkes_2018are the final settings used in Learning compositionally through attentive guidance(Hupkes et al. 2018).I tried to keep a minimal number of default settings under
baseline_2018andHupkes_2018, but we can probably cut further. Let me know if you think this is sensible or if you would remove some further, maybe even include general default under thetask_defaults.