Fix clang warnings. #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In the tests, we were getting the warnings because the variable in question was used only in assert(), which was being suppressed. Rather then suppress the unused variable warning, instead undefine NDEBUG for these sources so that the assertions are always there. |
tmadlener
approved these changes
Oct 13, 2025
Unused variables.
tmadlener
force-pushed
the
clang-20251011
branch
from
e28da62 to
f5e4d29
Compare
Contributor
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused variables.
BEGINRELEASENOTES
ENDRELEASENOTES