Fix Style/ItAssignment cop #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
response_handlermethod inlib/hawk/http.rbpreviously used the variable nameitto store request information for error messages.Ruby 3.4 introduces a new special variable
itfor single-line blocks. Usingitas a local variable can now cause confusion or unexpected behavior, especially as Ruby evolves. The new RuboCop Style/ItAssignment cop enforces this best practice.This commit renames the local variable
itfor clarity and future compatibility. No functional changes.Additionally, use interpolation instead of array join for performance
See: https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/