Two issues fixed: #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejbanakiewicz93
commented
Sep 28, 2023
maciejbanakiewicz93
commented
- Gets rid of the warning messages in the command line about unclosed resource files (with the original implementation the stream is never closed)
- We faced the issue with default values of keyword arguments - as soon as the debug library was activated all default values of arguments such as ${None}, ${True} etc. have been escaped (preceded with \) hence logical conditions in our custom keywords did not work anymore.
added 3 commits
September 28, 2023 10:59
1. Warning messages in the command line about unclosed files
2. Default values of keyword arguments (mostly booleans) are not processed correctly, e.g. ${True} is recognized as a string, not a boolean
This reverts commit e4aace5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.