feat: stop the program in raw mode if we recive "q" in stdin #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmaSd
changed the title
Collaborator
Author
|
I realized that the app already listens to "q" to exit, but because crossterm poll can't read stdin at the same time it doesn't work crossterm-rs/crossterm#396 So I changed stop to q to match the current behavior Also it know listen to input on a separate thread because otherwise it will block and will only read the first input correcttly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is I have some programs that use bandwhich --raw, I usually run it with
pkexecThe issue is to close bandhwich , the only way currently is to kill it and not only that I need to use
pkexec killwhich is just a bad experience for the user. (2 password prompts instead if 1)This simple idea resolves the issue, bandwhich now just listens to a stop command in raw mode to exit.