-
Notifications
You must be signed in to change notification settings - Fork 0
Improve user switching in Docker execution #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Refactor user switching logic for container execution.
WalkthroughAdds container-user detection to Changes
Sequence Diagram(s)sequenceDiagram
participant Script as auto_verify.sh
participant Container as Container
participant Build as Build Script
Script->>Container: run command to get current user
Container-->>Script: returns username / error
opt error determining user
Script->>Container: cleanup & stop container
Script-->>Script: exit with failure
end
alt username == "test"
Script->>Build: execute build script directly
Build-->>Script: build output/logs
else username != "test"
Script->>Container: su - test -c "run build script"
Container-->>Script: build output/logs
end
Script->>Script: capture logs & finalize
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor user switching logic for container execution.
Summary by CodeRabbit