Skip to content

Conversation

@halcwb
Copy link
Collaborator

@halcwb halcwb commented Dec 28, 2025

This pull request introduces two major sets of changes: a systematic migration in terminology from "Shape" and "Form" to "Orderable" throughout the codebase, and the addition of new property command handling for order scenarios in the OrderContext API. The terminology update affects type definitions, discriminated unions, and logic across multiple modules to improve clarity and consistency. The new property commands add fine-grained control for manipulating frequency, dose quantity, and dose rate properties within order scenarios, with corresponding updates to command processing and evaluation logic.

Terminology migration ("Shape"/"Form" → "Orderable"):

  • Updated the LimitTarget discriminated union in Types.fs and all related logic to replace FormLimitTarget with OrderableLimitTarget, and refactored associated helper functions and usages in modules such as DoseLimit, DoseRule, SolutionRule, and Medication to use the new terminology. [1] [2] [3] [4] [5] [6] [7] [8]
  • Updated documentation in genpres_resource_requirements.md to reflect the terminology change from "FormLimitTarget" to "OrderableTarget".

Order scenario property command enhancements:

  • Added new command cases to the OrderContext.Command discriminated union for adjusting frequency, dose quantity, and dose rate properties, including decrease, increase, set min/max/median operations.
  • Extended all relevant command handling functions (apply, map, toString, etc.) to support the new property commands, ensuring they are processed consistently within the order context. [1] [2] [3] [4]
  • Implemented the logic for evaluating these new property commands, including a helper function to process property commands when there is exactly one scenario with an order, ensuring robust and predictable behavior.

Other improvements and minor fixes:

  • Added utility functions for inclusive min/max creation in MinMax.fs to support new property logic.
  • Minor improvements in solution limit string conversion and dose rate constraints handling. [1] [2]
  • Removed or commented out unused AdjustUnit fields in Medication.fs for clarity. [1] [2] [3]

@halcwb halcwb merged commit 42fcb2c into informedica:master Dec 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant