Implementing property navigation #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two major sets of changes: a systematic migration in terminology from "Shape" and "Form" to "Orderable" throughout the codebase, and the addition of new property command handling for order scenarios in the
OrderContextAPI. The terminology update affects type definitions, discriminated unions, and logic across multiple modules to improve clarity and consistency. The new property commands add fine-grained control for manipulating frequency, dose quantity, and dose rate properties within order scenarios, with corresponding updates to command processing and evaluation logic.Terminology migration ("Shape"/"Form" → "Orderable"):
LimitTargetdiscriminated union inTypes.fsand all related logic to replaceFormLimitTargetwithOrderableLimitTarget, and refactored associated helper functions and usages in modules such asDoseLimit,DoseRule,SolutionRule, andMedicationto use the new terminology. [1] [2] [3] [4] [5] [6] [7] [8]genpres_resource_requirements.mdto reflect the terminology change from "FormLimitTarget" to "OrderableTarget".Order scenario property command enhancements:
OrderContext.Commanddiscriminated union for adjusting frequency, dose quantity, and dose rate properties, including decrease, increase, set min/max/median operations.apply,map,toString, etc.) to support the new property commands, ensuring they are processed consistently within the order context. [1] [2] [3] [4]Other improvements and minor fixes:
MinMax.fsto support new property logic.AdjustUnitfields inMedication.fsfor clarity. [1] [2] [3]