Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements across the codebase, primarily focusing on enhancing test reliability, cleaning up unused code, and improving the robustness of data path resolution. The most significant changes include a refactor of the
FilePathmodule to dynamically locate the data directory, removal of unused template test modules, and the addition of comprehensive parallel vs. sequential test coverage for the solver. Several test project files have also been updated for consistency and to remove unnecessary files.Core library improvements:
FilePathmodule to dynamically search for the data directory by traversing up from the current or assembly directory, improving robustness in different environments. This replaces the previous static path approach. (src/Informedica.ZIndex.Lib/FilePath.fs)Test infrastructure and cleanup:
Library.fs) from all test projects to reduce clutter and potential confusion. (tests/Informedica.DataPlatform.Tests/Library.fs,tests/Informedica.FHIR.Tests/Library.fs,tests/Informedica.FTK.Tests/Library.fs,tests/Informedica.GenCORE.Tests/Library.fs,tests/Informedica.GenPRES.Shared.Tests/Library.fs,tests/Informedica.HIXConnect.Tests/Library.fs) [1] [2] [3] [4] [5] [6]Library.fs, set consistent test project properties (such asGenerateProgramFileandIsPackable), and ensure only relevant source files are included. (tests/Informedica.DataPlatform.Tests/Informedica.DataPlatform.Tests.fsproj,tests/Informedica.FHIR.Tests/Informedica.FHIR.Tests.fsproj,tests/Informedica.FTK.Tests/Informedica.FTK.Tests.fsproj,tests/Informedica.GenPRES.Shared.Tests/Informedica.GenPRES.Shared.Tests.fsproj,tests/Informedica.HIXConnect.Tests/Informedica.HIXConnect.Tests.fsproj) [1] [2] [3] [4] [5]Testing and coverage improvements:
tests/Informedica.GenSOLVER.Tests/Tests.fs) [1] [2]Expecto.Flipfor improved test readability) across all test projects. (tests/Informedica.DataPlatform.Tests/Tests.fs,tests/Informedica.FHIR.Tests/Tests.fs,tests/Informedica.FTK.Tests/Tests.fs,tests/Informedica.HIXConnect.Tests/Tests.fs,tests/Informedica.GenPRES.Shared.Tests/Tests.fs,tests/Informedica.GenPRES.Shared.Tests/Main.fs) [1] [2] [3] [4] [5] [6] [7]These changes collectively improve the maintainability, reliability, and clarity of both the main library and its associated test projects.