Skip to content

Conversation

@halcwb
Copy link
Collaborator

@halcwb halcwb commented Dec 14, 2025

This pull request introduces several improvements across the codebase, primarily focusing on enhancing test reliability, cleaning up unused code, and improving the robustness of data path resolution. The most significant changes include a refactor of the FilePath module to dynamically locate the data directory, removal of unused template test modules, and the addition of comprehensive parallel vs. sequential test coverage for the solver. Several test project files have also been updated for consistency and to remove unnecessary files.

Core library improvements:

  • Refactored the FilePath module to dynamically search for the data directory by traversing up from the current or assembly directory, improving robustness in different environments. This replaces the previous static path approach. (src/Informedica.ZIndex.Lib/FilePath.fs)

Test infrastructure and cleanup:

  • Removed unused template test modules (Library.fs) from all test projects to reduce clutter and potential confusion. (tests/Informedica.DataPlatform.Tests/Library.fs, tests/Informedica.FHIR.Tests/Library.fs, tests/Informedica.FTK.Tests/Library.fs, tests/Informedica.GenCORE.Tests/Library.fs, tests/Informedica.GenPRES.Shared.Tests/Library.fs, tests/Informedica.HIXConnect.Tests/Library.fs) [1] [2] [3] [4] [5] [6]
  • Updated all test project files to remove references to Library.fs, set consistent test project properties (such as GenerateProgramFile and IsPackable), and ensure only relevant source files are included. (tests/Informedica.DataPlatform.Tests/Informedica.DataPlatform.Tests.fsproj, tests/Informedica.FHIR.Tests/Informedica.FHIR.Tests.fsproj, tests/Informedica.FTK.Tests/Informedica.FTK.Tests.fsproj, tests/Informedica.GenPRES.Shared.Tests/Informedica.GenPRES.Shared.Tests.fsproj, tests/Informedica.HIXConnect.Tests/Informedica.HIXConnect.Tests.fsproj) [1] [2] [3] [4] [5]

Testing and coverage improvements:

  • Added a comprehensive suite of tests comparing parallel and sequential equation solving in the GenSolver module, ensuring correctness and consistency between both approaches. (tests/Informedica.GenSOLVER.Tests/Tests.fs) [1] [2]
  • Added or updated test entry points and improved test module imports (notably, consistent use of Expecto.Flip for improved test readability) across all test projects. (tests/Informedica.DataPlatform.Tests/Tests.fs, tests/Informedica.FHIR.Tests/Tests.fs, tests/Informedica.FTK.Tests/Tests.fs, tests/Informedica.HIXConnect.Tests/Tests.fs, tests/Informedica.GenPRES.Shared.Tests/Tests.fs, tests/Informedica.GenPRES.Shared.Tests/Main.fs) [1] [2] [3] [4] [5] [6] [7]

These changes collectively improve the maintainability, reliability, and clarity of both the main library and its associated test projects.

@halcwb halcwb merged commit 35df6bc into informedica:master Dec 14, 2025
3 checks passed
@halcwb halcwb deleted the parallel-testing branch December 14, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant