Skip to content

Conversation

@halcwb
Copy link
Collaborator

@halcwb halcwb commented Dec 21, 2025

This pull request makes comprehensive changes to the codebase to rename the concept of "Shape" to "Form" throughout the Informedica.GenFORM.Lib library. This update affects API interfaces, data structures, function signatures, and internal logic to ensure consistency and clarity in terminology. The changes also update environment variable documentation for demo data.

API and Data Model Refactoring:

  • Renamed all references of "Shape" to "Form" in the IResourceProvider interface, related data structures, and function signatures in Api.fs, including methods like GetValidForms and GetFormRoutes and associated types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]

  • Updated downstream usage in other modules to replace "Shape" with "Form" in function parameters, record fields, and printed messages, such as in Check.fs and DoseRule.fs. [1] [2] [3] [4] [5]

Logic and Helper Function Updates:

  • Changed helper functions and logic to use "Form" instead of "Shape", including limit checks (isShapeLimitisFormLimit), dose rule construction, and duplicate detection comments. [1] [2] [3]

Documentation and Cleanup:

  • Updated the default demo data URL in the environment variable setup instructions in DEVELOPMENT.md.

  • Removed obsolete commented-out code related to the old "Shape" terminology in Api.fs. [1] [2]

These changes collectively ensure the codebase consistently uses "Form" instead of "Shape," improving clarity and aligning with domain terminology.

@halcwb halcwb merged commit 9ee40ce into informedica:master Dec 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant