chore: resolved discrepancy issues with location and shared filter ge… #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for organizational location (
Location) in reconstitution rules, patient categories, and related filtering logic throughout the codebase. The changes ensure that both department and location constraints are consistently modeled, parsed, and applied, aligning the implementation with updated domain documentation. Additionally, minor discrepancies and terminology mismatches between documentation and code have been addressed.Domain Model and Documentation Alignment
Location(organizational) andDepartment, and marked these fields as optional where appropriate. [1] [2]Locationconstraint and cleaned up related documentation sections for clarity. [1] [2]Type and Data Structure Updates
Location : string optionto theReconstitution,PatientCategory, andPatienttypes inTypes.fs, and updated all relevant code to handle the new field. [1] [2] [3]Parsing and Filtering Logic
Product.fsandSolutionRule.fsto extract bothLocationandDepartmentfrom resource sheets, making them optional and handling empty values gracefully. [1] [2] [3]LocationandDepartmentonly when both are specified, improving flexibility and correctness. [1] [2] [3]Patient Matching and Rule Application
DoseRule.fs,PrescriptionRule.fs) to correctly pass and handle location and department parameters in the correct order. [1] [2]Other Improvements
Patienttype for easier access and mutation.These changes collectively enhance the flexibility and correctness of reconstitution rule selection and patient matching, and bring the codebase into alignment with the latest domain requirements.