fix(wiki-editor): no duplicate buttons #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiEditor toolbars are automatically loaded for textareas with `id="wpTextbox1"`. close #11
审阅者指南 (在小型 PRs 中折叠)审阅者指南此 PR 重新组织了 ext.wikiEditor 模块的加载方式，通过在检查 addWikiEditor 函数是否存在之后才延迟加载器，确保 addWikiEditor 只被调用一次，从而防止重复的工具栏按钮。 WikiEditor 工具栏初始化逻辑的序列图sequenceDiagram
participant Plugin as "WikiEditor Plugin"
participant mw as "window.mw"
participant Loader as "mw.loader"
participant Textarea as "wpTextbox1 textarea"
Plugin->>Textarea: Check for textarea and registration
alt addWikiEditor exists
Plugin->>mw: Call addWikiEditor($(textarea))
else addWikiEditor does not exist
Plugin->>Loader: Load 'ext.wikiEditor'
end
文件级别变更
相关问题评估
可能相关的问题
提示和命令与 Sourcery 互动
自定义您的体验访问您的 仪表盘 以：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR reorganizes the loading of the ext.wikiEditor module so that addWikiEditor is invoked only once, preventing duplicate toolbar buttons by deferring the loader until after checking for the existence of the addWikiEditor function. Sequence diagram for WikiEditor toolbar initialization logicsequenceDiagram
participant Plugin as "WikiEditor Plugin"
participant mw as "window.mw"
participant Loader as "mw.loader"
participant Textarea as "wpTextbox1 textarea"
Plugin->>Textarea: Check for textarea and registration
alt addWikiEditor exists
Plugin->>mw: Call addWikiEditor($(textarea))
else addWikiEditor does not exist
Plugin->>Loader: Load 'ext.wikiEditor'
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
你好 - 我已经审阅了你的修改，它们看起来很棒！
帮助我更有用！请在每条评论上点击 👍 或 👎，我将利用这些反馈来改进你的评论。
Original comment in English
Hey there - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Deploying ipe-plugin-registry with
|
| Latest commit: |
331ad25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://743c403a.plugin-registry.pages.dev |
| Branch Preview URL: | https://bhsd-wiki-editor.plugin-registry.pages.dev |
There are two entries of `@bhsd/codemirror-mediawiki`: [wiki.min.js](https://cdn.jsdelivr.net/npm/@bhsd/codemirror-mediawiki/dist/wiki.min.js) is IIFE and [mw.min.js](https://cdn.jsdelivr.net/npm/@bhsd/codemirror-mediawiki/dist/mw.min.js) is ESM. Wikiplus uses wiki.min.js while IPE uses mw.min.js, which means the package may be loaded twice on the same page.
Member
|
我需要确认一下，是否可以移除 IPE 的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WikiEditor toolbars are automatically loaded for textareas with
id="wpTextbox1".close #11
Sourcery 总结
错误修复:
Original summary in English
Summary by Sourcery
Bug Fixes: