Обновляем тесты для поддержки новых версий ruby и activesupport #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ngoral
commented
Sep 10, 2025
ngoral
commented
- Убираем уже неподдерживаемые ruby < 2.7
- При помощи appraisal тестируем руби с новыми версиями rails >= 7.1
Минимально поддерживаемые рельсы 7.1 требуеют ruby >= 2.7
Vasfed
reviewed
Sep 10, 2025
.github/workflows/test.yml
Outdated
| rails-version: 72 | ||
| - ruby: 3.2 | ||
| rails-version: 72 | ||
| - ruby: 3.2 |
Contributor
There was a problem hiding this comment.
Suggested change
| - ruby: 3.2 | |
| - ruby: 3.4 |
Contributor
Author
There was a problem hiding this comment.
Согласна, что надо добавить ещё 3.3 и 3.4. Добавила.
только в данном конкретном случае это были 3.2 + 8.0 =)
Vasfed
approved these changes
Sep 10, 2025
imFawkes
reviewed
Sep 10, 2025
| end | ||
|
|
||
| s.required_ruby_version = '>= 1.9' | ||
| s.required_ruby_version = '>= 2.3' |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Ой, 2.3 -- это я забыла поправить. Спасибо! 2.7 теперь у нас
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.