Skip to content

Conversation

@Jayssgss
Copy link
Collaborator

@Jayssgss Jayssgss commented Nov 25, 2025

Updated Python SDK from release 1.306.1368 to 1.309.1268:

JIRA LINK: INSTA-66287

The files containing manual changes application_resources_api.py, and tag_filter.py, to bypass the pydantic failures that we are facing endpoints,and application services API calls via SDK.

Resolving Tag value serialization error on tag_filter.py.

PR will be raised on every instana release to update the SDK.

@vipinmenon
Copy link
Collaborator

@Jayssgss Please link the files to the description.

  1. Please mention from which version you are upgrading ?
  2. Please describe the changes you have made? What is this upgrade all about.? Why it is required?
  3. Are we going to do this regularly? If not at what interval?

@Jayssgss Jayssgss changed the title Update SDK to version 1.0.2 with coverage configuration Update SDK to version 1.0.2 with coverage configuration, JIRA LINK: https://jsw.ibm.com/browse/INSTA-66287 Dec 2, 2025
@vipinmenon
Copy link
Collaborator

At the high level I understand there are manual changes being done to the repository which is otherwise discouraged.

  1. How are we documenting this change so that this can be reverted and fixed formally.
  2. Do we have JIRA cards created against the respective teams to fix the original issues?

@Riyaksharma
Copy link

Kindly make sure the manual changes in the SDK have been flagged to the fixing team, so they can implement a permanent fix going forward.

@Jayssgss
Copy link
Collaborator Author

Jayssgss commented Dec 2, 2025

At the high level I understand there are manual changes being done to the repository which is otherwise discouraged.

  1. How are we documenting this change so that this can be reverted and fixed formally.
  2. Do we have JIRA cards created against the respective teams to fix the original issues?

Currently there is no specific documentation for the changes, but we have specified the application team to look into the issue for the openapi yaml, but no JIRA task is created for it yet.
As for reverting it, as of now the files have been added to the .openapi-generator-ignore file, which will ignore any changes to it in the future SDK generations, so once the application team has resolved the yaml for the endpoints and services API, we can remove these 2 files( application_resources_api.py, and tag_filter.py), from the .openapi-generator-ignore file and the changes will be reverted.

@Jayssgss
Copy link
Collaborator Author

Jayssgss commented Dec 2, 2025

Kindly make sure the manual changes in the SDK have been flagged to the fixing team, so they can implement a permanent fix going forward.

Yes it has been notified to the application team

@Jayssgss
Copy link
Collaborator Author

Jayssgss commented Dec 2, 2025

@Jayssgss Please link the files to the description.

  1. Please mention from which version you are upgrading ?
  2. Please describe the changes you have made? What is this upgrade all about.? Why it is required?
  3. Are we going to do this regularly? If not at what interval?

I have made the changes to the initial comment, let me know if we need anything else on it

Copy link
Collaborator

@vipinmenon vipinmenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few Review comments:

  1. Please make sure whenever you make a manual change, it goes as a separate commit so that it can be easily trackable.
  2. Create JIRA tickets as mentioned, to close track the team fixes it and we revert this manual changes.
  3. Since, we have now set the concerned files to ignore list, there can be compatibility issues to the API, whenever the development team brings in features to this APIs. So, its necessary that we keep track of those changes and make the changes manually until we revert this ignore list.
  4. Please add failures to the description to keep track of the cause of this manual change.

@Jayssgss Jayssgss merged commit b9e4b04 into main Dec 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants