-
Notifications
You must be signed in to change notification settings - Fork 5
Update SDK to version 1.0.2 with coverage configuration, JIRA LINK: https://jsw.ibm.com/browse/INSTA-66287 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Jayssgss Please link the files to the description.
|
|
At the high level I understand there are manual changes being done to the repository which is otherwise discouraged.
|
|
Kindly make sure the manual changes in the SDK have been flagged to the fixing team, so they can implement a permanent fix going forward. |
Currently there is no specific documentation for the changes, but we have specified the application team to look into the issue for the openapi yaml, but no JIRA task is created for it yet. |
Yes it has been notified to the application team |
I have made the changes to the initial comment, let me know if we need anything else on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few Review comments:
- Please make sure whenever you make a manual change, it goes as a separate commit so that it can be easily trackable.
- Create JIRA tickets as mentioned, to close track the team fixes it and we revert this manual changes.
- Since, we have now set the concerned files to ignore list, there can be compatibility issues to the API, whenever the development team brings in features to this APIs. So, its necessary that we keep track of those changes and make the changes manually until we revert this ignore list.
- Please add failures to the description to keep track of the cause of this manual change.
Updated Python SDK from release 1.306.1368 to 1.309.1268:
JIRA LINK: INSTA-66287
The files containing manual changes application_resources_api.py, and tag_filter.py, to bypass the pydantic failures that we are facing endpoints,and application services API calls via SDK.
Resolving Tag value serialization error on tag_filter.py.
PR will be raised on every instana release to update the SDK.