Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/e2e-nvidia-l4-x1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
run: |
cat /etc/os-release
mkdir -p /home/tmp
sudo dnf install -y gcc gcc-c++ make git-core python3.11 python3.11-devel util-linux
sudo dnf install -y gcc gcc-c++ make git-core python3.12 python3.12-devel util-linux

- name: Set XFS retries for root disk
run: |
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
- name: Install ilab
working-directory: ./instructlab
run: |
PYTHON=python3.11 ./scripts/install-ilab-with-cuda.sh
PYTHON=python3.12 ./scripts/install-ilab-with-cuda.sh

- name: Update instructlab-sdg library
working-directory: ./sdg
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-nvidia-l40s-x4.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
run: |
cat /etc/os-release
mkdir -p /home/tmp
sudo dnf install -y gcc gcc-c++ make git-core python3.11 python3.11-devel
sudo dnf install -y gcc gcc-c++ make git-core python3.12 python3.12-devel

- name: Checkout instructlab/instructlab
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:
- name: Install ilab
working-directory: ./instructlab
run: |
PYTHON="python3.11" ./scripts/install-ilab-with-cuda.sh
PYTHON="python3.12" ./scripts/install-ilab-with-cuda.sh

- name: Update instructlab-sdg library
working-directory: ./sdg
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/functional-gpu-nvidia-t4-x1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:
- name: Install Packages
run: |
cat /etc/os-release
sudo dnf install -y gcc gcc-c++ make git python3.11 python3.11-devel
sudo dnf install -y gcc gcc-c++ make git python3.12 python3.12-devel

- name: Checkout instructlab/sdg
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -133,13 +133,13 @@ jobs:
- name: Install instructlab/sdg
run: |
export PATH="/home/ec2-user/.local/bin:/usr/local/cuda/bin:$PATH"
python3.11 -m venv --upgrade-deps venv
python3.12 -m venv --upgrade-deps venv
. venv/bin/activate
nvidia-smi
python3.11 -m pip install tox tox-gh>=1.2 -c constraints-dev.txt
python3.11 -m pip cache remove llama_cpp_python
python3.12 -m pip install tox tox-gh>=1.2 -c constraints-dev.txt
python3.12 -m pip cache remove llama_cpp_python

CMAKE_ARGS="-DLLAMA_CUDA=on" python3.11 -m pip install -r requirements-dev.txt -c constraints-dev.txt
CMAKE_ARGS="-DLLAMA_CUDA=on" python3.12 -m pip install -r requirements-dev.txt -c constraints-dev.txt

- name: Check disk before tests
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ jobs:
# https://github.com/actions/checkout/issues/249
fetch-depth: 0

- name: Setup Python 3.11
- name: Setup Python 3.12
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: 3.11
python-version: 3.12
cache: pip
cache-dependency-path: |
**/pyproject.toml
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,7 @@ jobs:
- "3.12"
platform:
- "ubuntu-latest"
include:
- python: "3.11"
platform: "macos-latest"
- python: "3.12"
platform: "macos-latest"
- "macos-latest"
steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down
4 changes: 2 additions & 2 deletions docs/ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ All functional tests currently live in the `tests/functional` directory and are
We have two types of functional tests - non-GPU and GPU. To run the non-GPU functional tests, you can run `tox -e functional`. To run the GPU functional tests,
you can run `tox -e functional-gpu`.

In CI, the non-GPU tests are run with Python 3.10 - 3.12 on Ubuntu and MacOS runners - you can see the details [here](https://github.com/instructlab/sdg/blob/main/.github/workflows/test.yml)
In CI, the non-GPU tests are run on Ubuntu and MacOS runners - you can see the details [here](https://github.com/instructlab/sdg/blob/main/.github/workflows/test.yml)

The GPU tests are run with Python 3.11 on CentOS runners with access to a single NVIDIA Tesla T4 GPU with 16GB of vRAM - you can see the details [here](https://github.com/instructlab/sdg/blob/main/.github/workflows/functional-gpu-nvidia-t4-x1.yml)
The GPU tests are run on CentOS runners with access to a single NVIDIA Tesla T4 GPU with 16GB of vRAM - you can see the details [here](https://github.com/instructlab/sdg/blob/main/.github/workflows/functional-gpu-nvidia-t4-x1.yml)

## End-to-end (E2E) tests

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ from-first = true
known-local-folder = ["tuning"]

[tool.mypy]
python_version = "3.11"
python_version = "3.12"
disable_error_code = ["import-not-found", "import-untyped"]
exclude = [
"^src/instructlab/sdg/generate_data\\.py$",
Expand Down
8 changes: 6 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[tox]
# py3-unit runs unit tests with 'python3'
# py311-unit runs the same tests with 'python3.11'
# py312-unit runs the same tests with 'python3.12'
envlist = ruff, lint, mypy, spellcheck, py3-{unit, functional}
minversion = 4.4

Expand Down Expand Up @@ -106,5 +106,9 @@ allowlist_externals = *

[gh]
python =
3.12 = py312-{unitcov, functional}
3.11 = py311-{unitcov, functional}
3.12 = py312-{unitcov, functional}
3.13 = py313-{unitcov, functional}
3.14 = py314-{unitcov, functional}
3.15 = py315-{unitcov, functional}
3.16 = py316-{unitcov, functional}
Loading