Skip to content

Conversation

@kswiecicki
Copy link
Contributor

No description provided.

@kswiecicki kswiecicki requested review from a team as code owners December 9, 2025 14:26
@kswiecicki
Copy link
Contributor Author

@pbalcer, experimental header zex_graph.h is unavailable in when installing compute-runtime release package from https://github.com/intel/compute-runtime/releases. To avoid compilation failure involving unknown ze_graph_handle_t structure I've temporarily hardcoded compute-runtime fetching, which includes latest experimental headers.
As a final solution, should I copy this header and paste it into the L0 adapters subdirectory?

@kswiecicki
Copy link
Contributor Author

@lslusarczyk I've removed the UR_DFAILURE from ZE2UR_CALL_THROWS because it makes handling exception impossible when in debug mode.

@pbalcer
Copy link
Contributor

pbalcer commented Dec 9, 2025

As a final solution, should I copy this header and paste it into the L0 adapters subdirectory?

Yes, I think we should do that for all experimental level-zero APIs we use.

UR_DFAILURE aborts program before throwing an exception making it
impossible to handle it using try catch.
@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 102ed3d to 4b1d1ce Compare December 12, 2025 08:44
@kswiecicki
Copy link
Contributor Author

Intel(R) Arc(TM) B580 Graphics 20.1.0

Done, I've turned off those tests and created an issue for this: #20884.

Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

Comment on lines 27 to 32
using urQueueBeginCaptureIntoPupulatedGraphExpTest =
uur::urGraphPopulatedExpTest;

UUR_INSTANTIATE_DEVICE_TEST_SUITE(urQueueBeginCaptureIntoPupulatedGraphExpTest);

TEST_P(urQueueBeginCaptureIntoPupulatedGraphExpTest, InvalidNonEmptyGraph) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using urQueueBeginCaptureIntoPupulatedGraphExpTest =
uur::urGraphPopulatedExpTest;
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urQueueBeginCaptureIntoPupulatedGraphExpTest);
TEST_P(urQueueBeginCaptureIntoPupulatedGraphExpTest, InvalidNonEmptyGraph) {
using urQueueBeginCaptureIntoPopulatedGraphExpTest =
uur::urGraphPopulatedExpTest;
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urQueueBeginCaptureIntoPopulatedGraphExpTest);
TEST_P(urQueueBeginCaptureIntoPopulatedGraphExpTest, InvalidNonEmptyGraph) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied your suggestion.

@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 919fad7 to a1fd0d9 Compare December 15, 2025 12:19
@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 80d2872 to a1fd0d9 Compare December 15, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants