[SYCL] Add tanh in BF16 math #20883
Merged
[SYCL] Add tanh in BF16 math #20883
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
Hi, @xtian-github |
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Dec 12, 2025
YuriPlyakhin
approved these changes
Dec 12, 2025
Contributor
Author
|
Hi, @intel/dpcpp-specification-reviewers |
Contributor
Author
|
Hi, @intel/dpcpp-specification-reviewers |
steffenlarsen
approved these changes
Dec 15, 2025
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
LGTM, though I wonder if there's a reason we don't offer tan, sinh and cosh?
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
I have no idea about this but think we can add these functions as well. |
Contributor
Author
|
Hi, @intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received request for tanh in bfloat16 math functions. This PR adds it for SPIRV targets using fp32 emulation and update extension doc.