[SYCL] Use compiler's implementation for default marray constructor #20888
+14
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation of marray default constructor uses list-initialization to initialize elements, which leads to "value-initalization" of each element instead of default-initialization required by the SYCL specification. The fix caught a few places in the tests where marray is used in the constexpr context without initialization.
bader
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bader
changed the title
Default marray constructor does not zero initializes int32_t type elements.
bader
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
approved these changes
Dec 15, 2025
Contributor
Author
|
@intel/sycl-matrix-reviewers, ping. |
Contributor
Author
|
@intel/sycl-matrix-reviewers, please, take a look. |
YixingZhang007
approved these changes
Dec 16, 2025
Contributor
YixingZhang007
left a comment
YixingZhang007
left a comment
There was a problem hiding this comment.
Changes LGTM! Thank you!
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of marray default constructor uses
list-initialization to initialize elements, which leads to
"value-initalization" of each element instead of default-initialization
required by the SYCL specification.
The fix caught a few places in the tests where marray is used in the
constexpr context without initialization.