Bakhmat Vladislav #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeiBuzuma
added
the
[Deadline] Iteration 1-2
rssreader/rssreader.py
Outdated
| print(open(file, 'r').read()) | ||
|
|
||
|
|
||
| def news_parsing(): |
Collaborator
There was a problem hiding this comment.
К сожалению, не работает
# rss-reader https://news.tut.by/rss/geonews/minsk.rss
Traceback (most recent call last):
File "/usr/local/bin/rss-reader", line 8, in <module>
sys.exit(main())
File "/usr/local/lib/python3.8/site-packages/rssreader/cmd.py", line 5, in main
rssreader.main()
File "/usr/local/lib/python3.8/site-packages/rssreader/rssreader.py", line 60, in main
news_parsing()
File "/usr/local/lib/python3.8/site-packages/rssreader/rssreader.py", line 22, in news_parsing
making_log(1, "Opened URL for news reading, URL: %s" % args.source)
NameError: name 'args' is not defined
rssreader/rssreader.py
Outdated
|
|
||
| def filewrite(self): | ||
| for index in range(len(self.title)): | ||
| fp=open("feeddata.txt","a") |
Collaborator
There was a problem hiding this comment.
Обычно работа с файлами идет через контекстные менеджеры, очень советую их использовать :)
| self.links=[] | ||
| self.datalist=[] | ||
|
|
||
| def feed_find(self): |
Collaborator
There was a problem hiding this comment.
Советую добавить тут докстринги. Сложновато понять, что это функция делает
…read README for understanding. Good luck :)))
Collaborator
|
Выдает следующую ошибку при попытке установить пакет (из-за того, что пропущена запятая в зависимостях) ERROR: Could not find a version that satisfies the requirement fpdf==1.7.2lxml==4.4.1 (from rssreader==1.3) (from versions: 1.7, 1.7.2)
ERROR: No matching distribution found for fpdf==1.7.2lxml==4.4.1 (from rssreader==1.3) |
Collaborator
|
При попытке сгенерировать новости в pdf создается только картинка, но самого pdf файла нет |
Author
такой расклад существует при условии если текст содержит кирилицу или некие некодируемые символы, вроде я описал такое в readme |
AlexeiBuzuma
added
3-4 iteration | not implemented
[1-2 iteration] Minimal requirements checked
and removed
Hard Deadline
[Deadline] Iteration 1-2
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.