Add back //flip and //rotate #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
- Selection now takes in Vector3 instead of integers - Fixed a (potential, faced it due to a bug) crash when loading sessions from json caused by undefined shape properties - Removed some unnecessary return values from methods - Fixed some crashes when updating Outline or Scoreboard - Updated rotate action to use the API method - Added Shape::rotate() - Fixed crash with ScoreFactory when leaving the server - Added many try-catch blocks and debug TODO remove
TODO make compatible with JE debug stick NBT
- Inform user about crashed tasks - Fix empty rotation data on async threads (hack, TODO store globabally/shared) - Use libblockstate's replaceBlockStateValue method for rotate/flip/debug stick - Change blockstates in replace/flip - Added API::entryToState() and API::stateToEntry() - Added API::rotateBlockState() to allow rotating on async and main thread - removed old var_dump()'s - Require libblockstate 0.1.0 to support rotation/flip
No idea why usersession would be null.. but it happened, so here is a fix.
… use libstructure 0.2.0
Fixed void chunks, place offset works again Removed fast chunk render hack Replace leftover AsyncChunkManager with AsyncWorld
inxomnyaa
force-pushed
the
experiment/flip-rotate
branch
from
520128a to
5c92b84
Compare
inxomnyaa
force-pushed
the
experiment/flip-rotate
branch
from
5c92b84 to
dd31cb6
Compare
TODO: improve speeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #252