Feat/audit trails api roles management #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First implementation of the permission module based on a `Permission` enum * Unit tests for the `Permission` enum * Renamed `AuditTrail::permissions` to `AuditTrail::roles` * Renamed all modules and type-names from plural to singular name * audit_trails -> audit_trail * permissions -> permission * capabilities -> capability
Unit tests are still buggy and will be fixed with the next commit.
itsyaasir
reviewed
Dec 23, 2025
Contributor
itsyaasir
left a comment
itsyaasir
left a comment
There was a problem hiding this comment.
Everything looks good except some few nitpicks.
Note: Missing negative tests (permission denied scenarios, invalid inputs) (can be done in upcoming PRs)
Rename MetaDataUpdate to MetadataUpdate Co-authored-by: Yasir <yasir@shariff.dev>
…corresponding tests
…otaledger/notarization into feat/audit-trails-api-roles-management
…e verb-subject format
…-management # Conflicts: # audit-trail-move/sources/locking.move # audit-trails-move/sources/audit_trails.move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR provides a first version of the
Permissionenum, the initialrolesconfig and an "Admin" roleCapabilitycreation at AT object creation.Additionally:
PermissionenumPermissionenumAdmincap is not used in these tests)MetaDataAdminroleAuditTrail::permissionstoAuditTrail::roles* audit_trails -> audit_trail
* permissions -> permission
* capabilities -> capability