add support for logical replication protocol v3 #68
Conversation
|
It seems reasonable to me, but I don't have much context to evaluate the new interfaces. Maybe we could another reviewer to look it over? The only thing that struck me as odd was the casing of the |
|
|
||
| // MessageDecoderV2 decodes message from V2 protocol into struct. | ||
| type MessageDecoderV2 interface { | ||
| MessageDecoder |
There was a problem hiding this comment.
why remove this? similarly, why not have DecoderV3 inherit DecoderV2? It seems this is because V3 introduces new message types, & Decode was passing here off of baseMesssage?
would it be better to pass version as a parameter to Decode?
There was a problem hiding this comment.
Talking more, idea is that ParseV2 should return result of Parse like ParseV3 returns ParseV2 rather than using getCommonDecoder to have a V2 or V1 decoder where we call V2 (ignoring V1 method) if V2 implemented, otherwise call V1
3 participants
This version of the protocol allows subscribers to act on prepared transactions. Previously, the prepare part of prepared transactions was not visible to subscribers and they acted like committed/rolled back (only visible if streamed) transactions.
This protocol version adds new message types and doesn't change existing ones.
Tests added.