Handle more than 4 result columns from IDENTIFY_SYSTEM #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
I ran into the following error when using
pglogrepl.IdentifySystemon Alloy DB:It turns out Alloy DB returns an extra column named
thtoken. I'm not sure if the value is sensitive so I've blurred it out, but here's what the result looks like usingpsql:It looks like the columns are returned in the order
pglogrepl.IdentifySystemis expecting, so this PR makes it check if there's at least 4 result columns rather than requiring there be 4 columns. I've been running this change in production for a few hours now and it looks to have fixed the issue.