Skip to content

Conversation

@jon-mah
Copy link

@jon-mah jon-mah commented Jul 3, 2020

This PR implements a method for computing the false discovery rate for the random effects likelihood method for inferring sites under diversifying selection.

@skhilton: The purpose of this was to introduce the FDR control method. I computed the expected values by hand (actually by excel), to make sure that we are computing FDR correctly. When you get a chance, can you take a look at check over any of the things I might have missed?

@jon-mah jon-mah requested a review from skhilton July 3, 2020 03:52
@skhilton
Copy link
Collaborator

skhilton commented Jul 6, 2020

@jon-mah: When you get a chance can you look at the changes I made?

  1. I translated your code into pandas functions
  2. I added some writeup to the docs about the FDR.

Can you think of

  1. other places in the docs where we should talk about FDR?
  2. ways to make the current FDR text in the docs better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants