Fix unevaluatedProperties with adjacent bool additionalProperties test case

[414owen]

Unless I'm missing something, it looks like there's an additional property in the with no additional properties test case of the unevaluatedProperties with adjacent bool additionalProperties suite.

The case with additional properties is the next one.

[jdesrosiers]

Thanks for catching that! Can you make this change in the 2019-09 and v1 tests as well.

[414owen]

I think this is the only draft with this test?

$ command grep -nire 'unevaluatedProperties with adjacent bool additionalProperties' 
tests/draft2020-12/unevaluatedProperties.json:130:        "description": "unevaluatedProperties with adjacent bool additionalProperties",

It looks like 2019 has unevaluatedProperties with adjacent additionalProperties, and 2020 has the same with bool and non-bool additionalProperties. The other tests look fine.

[jdesrosiers]

Oh, that's weird. There's no reason there should be different tests in those three versions. It looks like someone broke that test in 2020-12, but didn't make the change in the other versions.

We need to make all three the same. I think the best approach is to use the 2019-09 version of the schema/tests and the 2020-12 version of the description. Then we need to copy the "unevaluatedProperties with adjacent non-bool additionalProperties" test to 2019-09 and v1.

[414owen]

@jdesrosiers Alright, I've updated all three drafts to match, with the bool and non-bool versions.

Note that the non-bool version doesn't actually test anything about the non-bool nature of the additionalProperties constraint.

[jdesrosiers]

Oh, I wasn't expecting you to change the non-bool test, just copy it over to the other versions. But, this way is better. The test for an invalid additional property in the original version was testing additionalProperties, not unevaluatedProperties.

Thanks for helping clean this up. Since we're changing an existing test, I'm going to leave this open for a little while to give more people a chance to review.