-
Notifications
You must be signed in to change notification settings - Fork 15
rfc(0020): table-schema-value-type #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I left some quite nitpicky comments about wording, not the design (which is on point IMO).
Co-authored-by: Georg Schwarz <dev@georg-schwarz.com>
georg-schwarz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please don't forget to change the status of the RFC before merging :-)
Btw, I noticed we introduce an inconsistency with this RFC:
- access to members via
row[<number/text>]brackets - access to text length via
value.lengthin constraints
See README.md