-
Notifications
You must be signed in to change notification settings - Fork 1
Add Chrome extension popup with checkbox controls and fix duplicate achievements display #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
Thanks for the review! I've addressed both comments:
The refactoring maintains all existing functionality while making the codebase more maintainable. (58177c8) |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
…rectly to src Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
…ssion Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
|
@copilot merge current main branch and update codebase if required |
Merged main branch successfully! The codebase has been updated with the latest project configuration changes including the switch from stylelint to biome, updated CI workflows, and modernized tooling setup. The extension functionality remains intact with the checkbox interface for sponsors and sponsoring controls. (26cf7d6) Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
| loadingText?: string; | ||
| } | ||
|
|
||
| export default function CheckboxSettings({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think old src/options/App.tsx is enough naming for that purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed CheckboxSettings.tsx to App.tsx to match the old options page naming convention as requested. (b3f2852)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. You renamed to src/App.tsx, you should keep original src/options/App.tsx for better reviewing experience.
I agree, the word options remind us for options page of chrome extension. However it is still having options feature and we don't need to consider confusions since dropped option page feature. How do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Moved the checkbox component from src/App.tsx to src/options/App.tsx to match the original main branch structure for better reviewing experience. The word "options" makes sense as it still contains options functionality, even though we dropped the dedicated options page. (ff06025)
Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
…structure Co-authored-by: kachick <1180335+kachick@users.noreply.github.com>
This PR implements a Chrome extension popup with simple checkbox controls for sponsors and sponsoring sections as requested in issue #87, and fixes a CSS selector issue that was causing duplicate achievements sections to appear on GitHub profiles.
Changes Made
Extension Manifest
actionconfiguration tomanifest.jsonwith popup, title, and icon settingsdisplay: noneto prevent element flash on page loadPopup Interface
popup.htmlwith a clean, compact interface using primer.css stylingpopup.cssfor popup-specific styling (320px width, proper spacing)popup.tsxwith React-based checkbox functionalityCheckbox Controls
The popup provides simple checkbox controls for individual features:
Simple Implementation
hiddenattribute for dynamic elements (sponsors, sponsoring)Bug Fix: Duplicate Achievements Display
Fixed an issue where multiple identical "Achievements" sections were appearing on GitHub profiles by using a more specific CSS selector. The achievements section now displays correctly without duplication.
UI Preview
The popup opens when clicking the extension icon in the Chrome toolbar, providing instant access to checkbox controls for sponsors and sponsoring sections.
Fixes #87.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.