Skip to content

fix(controller): use consistent ID format for agent deletion #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EItanya merged 1 commit into from
Dec 29, 2025
+18 −1
Merged

fix(controller): use consistent ID format for agent deletion #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go/internal/controller/reconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ func (a *kagentReconciler) ReconcileKagentAgent(ctx context.Context, req ctrl.Re
}

func (a *kagentReconciler) handleAgentDeletion(req ctrl.Request) error {
if err := a.dbClient.DeleteAgent(req.String()); err != nil {
id := utils.ConvertToPythonIdentifier(req.String())
if err := a.dbClient.DeleteAgent(id); err != nil {
return fmt.Errorf("failed to delete agent %s: %w",
req.String(), err)
}
Expand Down
16 changes: 16 additions & 0 deletions go/internal/controller/reconciler/reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ package reconciler
import (
"testing"

"github.com/kagent-dev/kagent/go/internal/utils"
"github.com/stretchr/testify/assert"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
)

// TestComputeStatusSecretHash_Output verifies the output of the hash function
Expand Down Expand Up @@ -191,3 +193,17 @@ func TestComputeStatusSecretHash_Deterministic(t *testing.T) {
})
}
}

func TestAgentIDConsistency(t *testing.T) {
req := reconcile.Request{
NamespacedName: types.NamespacedName{
Namespace: "test-namespace",
Name: "my-agent",
},
}

storeID := utils.ConvertToPythonIdentifier(utils.ResourceRefString(req.Namespace, req.Name))
deleteID := utils.ConvertToPythonIdentifier(req.String())

assert.Equal(t, storeID, deleteID)
}
Loading