-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add node-not-ready event monitoring support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add node-not-ready event monitoring support #12
Conversation
antweiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Just need to remove the redundant .sh file in helm requirements.lock and sign off the commit
.gitignore
Outdated
| # Generated files | ||
| *.pb.go | ||
| zz_generated.*.go | ||
| zz_generated.*.gobuild-multiarch.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it dosen't necessary.
i'll delete it
|
Thank you for this! Also - if you have any thoughts on how to make new event support more streamlined - LMK. |
|
hi @kyungho-for-ops - waiting for you to sign this off. |
|
Hi @antweiss I've rebased the branch using git rebase HEAD~4 --signoff and force-pushed to fix all DCO issues. All commits should now be signed off correctly. Could you please approve the pending workflow so the CI/CD checks (Docker Build, Test) can start? Once the checks pass, I would appreciate your final approving review for merging. Thank you for your patience! |
antweiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit (trigger final checks) isn't signed-off :))
- Add 'node-not-ready' event type to EventConfiguration enum - Implement mapNodeEventType function in event watcher - Update event type filtering to handle Node events separately from Pod events - Update CRD schemas to include node-not-ready event type - Update documentation and examples with node monitoring capabilities - Generate updated deepcopy code for API changes This enables khook to monitor Kubernetes node readiness events and trigger appropriate agent responses for node-level issues like kubelet failures, network problems, or resource pressure. Signed-off-by: Kyungho Kang <kyungho@dable.io>
Signed-off-by: kyungho-for-ops <kyungho1495@gmail.com> Signed-off-by: Kyungho Kang <kyungho@dable.io>
Signed-off-by: kyungho-for-ops <kyungho1495@gmail.com> Signed-off-by: Kyungho Kang <kyungho@dable.io>
Signed-off-by: Kyungho Kang <kyungho@dable.io>
d48bd3c to
b435184
Compare
|
Sorry for the late response; I just got back last night. I've finished the changes. |
Overview
This PR adds support for monitoring Kubernetes Node
node-not-readyevents in khook, enabling the system to detect and respond to node-level issues automatically.What Changed
✨ New Features
node-not-readyevent type to supported event configurationsmapNodeEventType)🔧 Technical Changes
EventConfigurationenum withnode-not-readytypemapNodeEventTypefunction for node-specific events📚 Documentation Updates
Files Modified
Usage Example
Testing
Breaking Changes
❌ None - This is a purely additive feature maintaining full backward compatibility.
Type of Change