Add operational data journal with retention policy #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dump operational datastore to timestamped JSON snapshots every 5 minutes (in /var/lib/statd/). The operational.json symlink always points to the latest snapshot. Implement hierarchical retention policy that keeps the first snapshot of each time period (hour/day/week/month/year), providing fine-grained recent history while preventing unbounded disk usage. This will allow us to plot / track how the system state evolves as well as give us somewhat fine-grained info in the case of an event, such as a crash. Add unit test simulating months of snapshots to verify retention behavior using a statd stub that only runs the retention code locally (unit test) Signed-off-by: Richard Alpe <richard@bit42.se>
wkz
requested changes
Dec 9, 2025
src/statd/journal.c
Outdated
Comment on lines
52
to
53
| ret = lyd_print_path(timestamp_path, tree, LYD_JSON, | ||
| LYD_PRINT_WITHSIBLINGS); |
Contributor
There was a problem hiding this comment.
Did some quick testing on a 28-port system with more or less an empty config:
root@test-05-25-f8:/tmp$ sysrepocfg -X -d operational -f json >oper.json
root@test-05-25-f8:/tmp$ ll -h oper.json
-rw-r--r-- 1 root root 237.9K Dec 9 22:36 oper.json
root@test-05-25-f8:/tmp$ gzip oper.json
root@test-05-25-f8:/tmp$ ll -h oper.json.gz
-rw-r--r-- 1 root root 19.6K Dec 9 22:37 oper.json.gz
Should we pass this through libz before going to disk? I'd hate for this storage to become an issue on smaller systems or as the amount of generated data grows. With compression, disk usage after one year should go from 14MB down to 1MB with today's feature-set. That should set us up to not have to think about this for a long time.
Store historical snapshots as compressed .json.gz files to reduce disk usage. The operational.json file remains uncompressed for easy access. Signed-off-by: Richard Alpe <richard@bit42.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dump operational datastore to timestamped JSON snapshots every 5 minutes (in /var/lib/statd/). The operational.json symlink always points to the latest snapshot.
Implement hierarchical retention policy that keeps the first snapshot of each time period (hour/day/week/month/year), providing fine-grained recent history while preventing unbounded disk usage.
This will allow us to plot / track how the system state evolves as well as give us somewhat fine-grained info in the case of an event, such as a crash.
Add unit test simulating months of snapshots to verify retention behavior using a statd stub that only runs the retention code locally (unit test)
Checklist
Tick relevant boxes, this PR is-a or has-a: