Skip to content

Use mountPath while upserting volumeMounts #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tamalsaha merged 3 commits into from
Dec 9, 2025
Merged

Use mountPath while upserting volumeMounts #633

tamalsaha merged 3 commits into from
Dec 9, 2025

Conversation

@fr-sarker
Copy link
Contributor

@fr-sarker fr-sarker commented Dec 9, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ArnobKumarSaha
Copy link
Member

ArnobKumarSaha commented Dec 9, 2025

Not needed.
Use different names.

@ArnobKumarSaha ArnobKumarSaha reopened this Dec 9, 2025
@ArnobKumarSaha
Copy link
Member

ArnobKumarSaha commented Dec 9, 2025

Needed for neo4j volumeMounts

   - mountPath: /config/neo4j-auth
      name: neo4j-auth
    - mountPath: /backups
      name: data
      subPathExpr: backups
    - mountPath: /data
      name: data
      subPathExpr: data
    - mountPath: /import
      name: data
      subPathExpr: import
    - mountPath: /licenses
      name: data
      subPathExpr: licenses
    - mountPath: /logs
      name: data
      subPathExpr: logs/$(POD_NAME)
    - mountPath: /metrics
      name: data
      subPathExpr: metrics/$(POD_NAME)

@ArnobKumarSaha ArnobKumarSaha changed the title update condition Use mountPath while upserting volumeMounts Dec 9, 2025
@fr-sarker @tamalsaha
update condition
25bea0c 
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
@fr-sarker @tamalsaha
update Condition
b4287f2 
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
@tamalsaha
Copy link
Contributor

tamalsaha commented Dec 9, 2025 •
edited
Loading

https://github.com/kubernetes/api/blob/382014e64b8e968a848ca4fa97d63addcb6af126/core/v1/types.go#L3014-L3021

Screenshot 2025-12-09 at 7 28 39 PM

I think we should probably merge just based on mountPath. That is what k8s itself is doing.

wdyt?

@fr-sarker
Copy link
Contributor Author

fr-sarker commented Dec 9, 2025

Agreed. Sticking to how k8s handles it is the best approach.

@tamalsaha
fix
2c84e72 
Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha merged commit 0558d1d into master Dec 9, 2025
3 checks passed
@tamalsaha tamalsaha deleted the update-condition branch December 9, 2025 15:10
tamalsaha added a commit that referenced this pull request Dec 9, 2025
@fr-sarker @tamalsaha
Use mountPath while upserting volumeMounts (#633)
9cc8e60 
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
Co-authored-by: Tamal Saha <tamal@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArnobKumarSaha ArnobKumarSaha Awaiting requested review from ArnobKumarSaha

@tamalsaha tamalsaha Awaiting requested review from tamalsaha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fr-sarker @CLAassistant @ArnobKumarSaha @tamalsaha