Skip to content

Conversation

@kolt-mcb
Copy link
Owner

Summary

  • introduce quicksort.fra as a new fraglets sorting demo
  • document quicksort usage in README
  • mention quicksort in INSTRUCTION_SET
  • clean up trailing text in sort.fra

Testing

  • pip install .
  • pytest -q

https://chatgpt.com/codex/tasks/task_e_687345cdf5fc83248d6a772a56f056e2

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduces a new experimental quicksort example in the Fraglets demo, updates documentation to include usage instructions, and removes a stray line from the existing selection sort file.

  • Add quicksort.fra with a recursive quicksort fraglet implementation
  • Document quicksort in README.md and docs/INSTRUCTION_SET.md
  • Clean up leftover demo line in sort.fra

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
sort.fra Removed trailing commented demo fragment
quicksort.fra New file: experimental quicksort implementation
docs/INSTRUCTION_SET.md Added “Experimental QuickSort” section
README.md Added quicksort usage example and instructions
Comments suppressed due to low confidence (3)

quicksort.fra:25

  • [nitpick] State labels mix a qs_ prefix (e.g. qs_part) with unprefixed names like less_sort and greater_sort. Consider adding a consistent qs_ prefix to these labels (e.g. qs_less_sort) to avoid collisions and improve readability.
[matchp less_sort match less qsort]

quicksort.fra:32

  • The new quicksort example isn’t covered by any automated test. Adding a pytest case that runs quicksort.fra with known inputs and verifies the sorted output would help catch future regressions.
[qsort 5 1 4 2 3]

docs/INSTRUCTION_SET.md:91

  • [nitpick] The quicksort section describes the approach but doesn’t include a usage snippet. Consider adding a short fraglet invocation (e.g. [qsort 3 1 2]) and expected result to illustrate how to run the example directly in this document.
## Experimental QuickSort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants