Skip to content

Conversation

@ScortYang
Copy link

This pull request introduces significant improvements to the ACME certificate management scripts and web interface, with a focus on supporting multiple Certificate Authorities (CAs), especially adding ZeroSSL as an option alongside Let's Encrypt. The changes enhance flexibility, improve user experience, and update file paths for better compatibility. Below are the most important changes grouped by theme:

Support for Multiple Certificate Authorities (CAs):

  • Added support for selecting between Let's Encrypt and ZeroSSL as the CA, including UI elements in Module_acme.asp and backend logic in acme_config.sh. The system now validates ZeroSSL email addresses and ensures proper registration and configuration when ZeroSSL is chosen. [1] [2] [3] [4] [5] [6] [7]

Backend Script Enhancements:

  • Introduced normalize_ca and ensure_ca_ready functions in acme_config.sh to handle CA selection, email validation, and account registration for ZeroSSL, improving robustness and error handling during certificate issuance. [1] [2]
  • Updated certificate installation logic to use --fullchain-file instead of --cert-file, and expanded the list of installation paths for better compatibility with different environments.

File Path and Environment Updates:

  • Changed script and ACME root paths from /koolshare/ to /jffs/.koolshare/ to align with updated directory structures, and ensured necessary directories are created as needed.
  • Added removal of additional certificate files and ensured HTTPD service restarts after certificate deletion or installation for improved reliability. [1] [2] [3]

Web Interface Improvements:

  • Enhanced the web UI to allow users to select the CA and input a ZeroSSL email when appropriate, with real-time validation and dynamic form updates. [1] [2] [3] [4] [5]

These updates collectively make the ACME integration more flexible, user-friendly, and maintainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant