735 #218
735 #218
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Pilgrim's Traverse deep dungeon content (floors 1-100 and The Final Verse bonus fight), along with various bug fixes and improvements to existing content. The changes include new trigger files for deep dungeon floors, updates to ability IDs in Arkveld EX, and maintenance updates across existing deep dungeon files.
- Adds comprehensive trigger support for Pilgrim's Traverse floors 1-100 and The Final Verse
- Updates Arkveld EX triggers with additional ability IDs and improved mechanics handling
- Fixes spelling errors, improves translations, and standardizes duplicate item handling across deep dungeon files
- Adds DeepDungeonExtras content type for bonus deep dungeon fights
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| util/zone_overrides.ts | Fixed typo in comment and populated synthetic content types |
| util/gen_coverage_report.ts | Added mapping for DeepDungeonExtras content type |
| ui/raidboss/data/07-dt/trial/arkveld-ex.ts | Updated ability IDs, added new triggers, improved Korean translations with directional arrows |
| ui/raidboss/data/07-dt/deepdungeon/pilgrims_traverse_*.ts | New trigger files for Pilgrim's Traverse floors 41-90 and The Final Verse |
| ui/raidboss/data/07-dt/deepdungeon/pilgrims_traverse_general.ts | New general triggers for all Pilgrim's Traverse floors (mimics, pomanders, floor notifications) |
| ui/raidboss/data/06-ew/deepdungeon/*.ts | Updated API URLs, improved translations, added default cases for duplicate item handling |
| ui/raidboss/data/04-sb/deepdungeon/heaven-on-high_general.ts | Removed obsolete pomander types, added default case, updated API URLs |
| ui/raidboss/data/03-hw/deepdungeon/the_palace_of_the_dead_general.ts | Removed obsolete pomander types, added default case, updated API URLs |
| resources/content_type.ts | Added new content types: DeepDungeonExtras, HallOfTheNovice, SeasonalEvents, TheDiadem |
| plugin/*/Properties/AssemblyInfo.cs | Version bump from 99.166.0.0 to 99.168.0.0 |
| package.json | Version bump from 99.166.0 to 99.168.0 |
| build/@.txt | Added reference file with various unicode symbols |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }; | ||
| data.chaseDir = matches.id === 'ABB3' ? 'cw' : 'ccw'; | ||
| if (data.dice === undefined) | ||
| return; |
There was a problem hiding this comment.
[nitpick] The assignment to data.chaseDir has been moved after the early return check for data.dice === undefined. This is correct, but the logic could be clearer by adding a comment explaining why the order matters, as the chase direction should only be set when dice data is available.
| return; | |
| return; | |
| // Only set chaseDir if dice data is available; order matters to avoid setting it when dice is undefined. |
| data.chases = (data.chases ?? 0) + 1; | ||
| if (data.dice === undefined) | ||
| return; | ||
| data.chases++; |
There was a problem hiding this comment.
The increment data.chases++ will fail if data.chases is undefined. The original code used nullish coalescing (data.chases ?? 0) + 1 to safely initialize. This should be changed to data.chases = (data.chases ?? 0) + 1 or initialized earlier to avoid a NaN result.
| data.chases++; | |
| data.chases = (data.chases ?? 0) + 1; |
| if (data.chases === data.dice) | ||
| return { infoText: output.avoid!() }; | ||
| if (data.chases < 5 && (data.chases + 4) === data.dice) { | ||
| if ((data.chases + 4) === data.dice) { |
There was a problem hiding this comment.
The condition data.chases < 5 && was removed. This change means the code will now execute for any chase count where (data.chases + 4) === data.dice, not just when chases is less than 5. Ensure this behavioral change is intentional and doesn't cause issues for chase counts >= 5.
| if ((data.chases + 4) === data.dice) { | |
| if (data.chases < 5 && (data.chases + 4) === data.dice) { |
|
|
||
| export default triggerSet; | ||
|
|
||
| // 추출: StartsCasting 14:([^:]*):Guardian Arkveld:([^:]*) |
There was a problem hiding this comment.
[nitpick] This Korean comment appears to be extraction notes for ability IDs. Consider removing debug/extraction comments from production code or adding an English translation for international maintainers.
| // 추출: StartsCasting 14:([^:]*):Guardian Arkveld:([^:]*) |
| 🔙🔚🔛🔜🔝 | ||
| ⊕︎⊗︎⌾︎⏺︎▢︎◉︎◎︎●︎◯︎☀︎☯︎☹︎☺︎☻︎☼︎🞅🞆🞇🞈🞉 | ||
| 🔴🟠🟡🟢🔵🟣🟤⚪⚫ | ||
| 🟥🟧🟨🟩🟦🟪🟫◻️◼️▪️▫️⬛⬜ | ||
| 🠜🠝🠞🠟 | ||
| 🡄🡅🡆🡇 | ||
| 🡐🡑🡒🡓 | ||
| 🡸🡹🡺🡻🡼🡽🡾🡿 | ||
| 🢀🢁🢂🢃🢄🢅🢆🢇 |
There was a problem hiding this comment.
[nitpick] This file contains only unicode symbols without context or explanation. If this is a reference file for available symbols to use in translations, consider adding a comment header explaining its purpose or moving it to a documentation folder rather than the build directory.
No description provided.