Fixes for makeHeadline and makeExternalLink in MediaWiki 1.43 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
and here is yet another approach to fix WikiMarkdown for current MediaWiki version 1.43. I used the calls that mediawiki itself uses internally so this should keep the best compatibility.
It also fixes calls to makeExternalLink. While this function is still contained in 1.43 it is already marked as deprecated, so it will be dropped in the next versions. So I already switched from Linker to LinkRenderer to be future proof.
Thanks,
Christopher