Skip to content

bugfix: handle space on node link #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atjhoendz merged 1 commit into from
Jun 10, 2025
Merged

bugfix: handle space on node link #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions slate_converter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const (
_nodeTypeInline = "inline"
_nodeTypeCaption = "caption"
_nodeTypeFigure = "figure"
_nodeTypeLink = "link"
)

// SlateLeaf represents a text element with optional formatting.
Expand Down Expand Up @@ -103,6 +104,9 @@ func serializeSlateNodes(nodes []SlateNode, nodeSeparator, leaveSeparator string
case _nodeTypeInline:
modifiedSlateNodeSeparator = _spaceSeparator
result.WriteString(serializeSlateNodes(node.Nodes, modifiedSlateNodeSeparator, leaveSeparator) + leaveSeparator)
case _nodeTypeLink:
modifiedSlateNodeSeparator = _spaceSeparator
result.WriteString(serializeSlateNodes(node.Nodes, modifiedSlateNodeSeparator, leaveSeparator))
case _nodeTypeListItem:
modifiedSlateNodeSeparator = _commaSeparator
if node.isLastInList {
Expand Down
50 changes: 50 additions & 0 deletions slate_converter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,53 @@ RedMagic 10 Pro+ berada di posisi ketiga dengan skor AnTuTu 2.879.356, diikuti o
assert.Nil(t, err)
assert.Equal(t, expected, result)
}

func Test_ToPlainText_Link(t *testing.T) {
t.Run("text link not contain space", func(t *testing.T) {
inputJSON := `{"document":{"nodes":[{"object":"block","type":"heading-large","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"ini adalah judul","marks":[]}]}]},{"object":"block","type":"paragraph","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"tanda kemunculan ","marks":[]}]},{"object":"inline","type":"link","data":{"href":"https://kumparan.com"},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"suzuki fronx","marks":[]}]}]},{"object":"text","leaves":[{"object":"leaf","text":" di indonesia.","marks":[]}]}]}]}}`
expected := `tanda kemunculan suzuki fronx di indonesia.`

input, err := ParseSlateDocument(inputJSON)
assert.NoError(t, err)

result, err := input.ToPlainText()
assert.NoError(t, err)
assert.Equal(t, expected, result)
})

t.Run("text link include space on prefix", func(t *testing.T) {
inputJSON := `{"document":{"nodes":[{"object":"block","type":"heading-large","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"ini adalah judul","marks":[]}]}]},{"object":"block","type":"paragraph","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"tanda kemunculan","marks":[]}]},{"object":"inline","type":"link","data":{"href":"https://kumparan.com"},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":" suzuki fronx","marks":[]}]}]},{"object":"text","leaves":[{"object":"leaf","text":" di indonesia.","marks":[]}]}]}]}}`
expected := `tanda kemunculan suzuki fronx di indonesia.`

input, err := ParseSlateDocument(inputJSON)
assert.NoError(t, err)

result, err := input.ToPlainText()
assert.NoError(t, err)
assert.Equal(t, expected, result)
})

t.Run("text link include space on suffix", func(t *testing.T) {
inputJSON := `{"document":{"nodes":[{"object":"block","type":"heading-large","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"ini adalah judul","marks":[]}]}]},{"object":"block","type":"paragraph","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"tanda kemunculan ","marks":[]}]},{"object":"inline","type":"link","data":{"href":"https://kumparan.com"},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"suzuki fronx ","marks":[]}]}]},{"object":"text","leaves":[{"object":"leaf","text":"di indonesia.","marks":[]}]}]}]}}`
expected := `tanda kemunculan suzuki fronx di indonesia.`

input, err := ParseSlateDocument(inputJSON)
assert.NoError(t, err)

result, err := input.ToPlainText()
assert.NoError(t, err)
assert.Equal(t, expected, result)
})

t.Run("text link include space on prefix and suffix", func(t *testing.T) {
inputJSON := `{"document":{"nodes":[{"object":"block","type":"heading-large","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"ini adalah judul","marks":[]}]}]},{"object":"block","type":"paragraph","data":{},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":"tanda kemunculan","marks":[]}]},{"object":"inline","type":"link","data":{"href":"https://kumparan.com"},"nodes":[{"object":"text","leaves":[{"object":"leaf","text":" suzuki fronx ","marks":[]}]}]},{"object":"text","leaves":[{"object":"leaf","text":"di indonesia.","marks":[]}]}]}]}}`
expected := `tanda kemunculan suzuki fronx di indonesia.`

input, err := ParseSlateDocument(inputJSON)
assert.NoError(t, err)

result, err := input.ToPlainText()
assert.NoError(t, err)
assert.Equal(t, expected, result)
})
}