Get rid of "disabled" on fields in BasicSettings. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It feels better to arrive and see all fields working and no puzzle to solve. Instead, set the preset to "custom" whenever a preset parameter is changed (see 1074b77).
There was a problem hiding this comment.
Pull Request Overview
This PR removes disabled state from input fields in the BasicSettings and RatiosInput components, making all fields immediately editable. The change improves user experience by eliminating the need for users to first change a preset setting to "custom" before being able to modify individual parameters.
- Removed
disabled={store.ratio !== "custom"}from ratio input fields - Removed
disabled={store.ratio !== "custom"}from guideline angle input field
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/RatiosInput.jsx | Removes disabled state from numeric ratio input fields |
| src/BasicSettings.jsx | Removes disabled state from guideline angle input field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kylev
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels better to arrive and see all fields working and no puzzle to solve. Instead, set the preset to "custom" whenever a preset parameter is changed (see 1074b77).