-
Notifications
You must be signed in to change notification settings - Fork 14
Modernize library and improve tests #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This avoids pulling in breaking releases without first explicitly defining compatibility. See http://semver.org/
To allow option values containing commas. -P is new in Pygments 0.9. http://pygments.org/docs/cmdline/#options-and-filters Fixes kzykhys#4.
The "guessed" lexer output in Pygments 2.2 differs from the output when manually providing the lexer. As a result, we need to also provide a file demonstrating the expected guessed output.
|
I'm following up to see if you've been able to take a look at this pull request yet. Have you given any thought to my offer to help maintain this library? Looking forward to hearing back. Thanks! |
|
I hope everything is okay. I'm truly concerned, since I haven't heard anything. Since I haven't heard back, I've decided to proceed with my fork. I've released version 1.0.0 of ramsey/pygments under the Thanks again for your library! If you'd ever like me to merge anything from my fork into your upstream repository, feel free to let me know. I'm happy to do so. Best regards! |
Scope
This pull request sets the minimum required PHP version to 5.6, bringing along with this requirement bump a number of updates, including:
^3.0-Prather than-Owhen passing optionsutil/install-php.shscript)This incorporates all the work from pull requests #3, #5, #6, #7, #9, and #10. Commit authors and dates for each of these PRs have been maintained in this PR.
This also addresses and fixes issues #1, #2, #4, and #8.
Version 2.0.0 Recommendation
If you choose to merge this PR, I recommend releasing the next version as 2.0.0, since the 1.x series supports PHP 5.3.2+ and symfony/process 2.3, and this PR makes the leap to PHP 5.6+ and symfony/process 3.0.
Communication and Maintenance Concerns
I've found this library to be very useful and helpful. However, the lack of movement or responsiveness to any issues or pull requests in over three years is concerning. I'd like to ensure a future for the work you began, and I'm volunteering to help maintain this library.
If I've not heard from you in two weeks, I will begin maintaining a fork of this library at https://github.com/ramsey/pygments. To avoid namespace and package name collisions in the Composer ecosystem, I will change the package name to
ramsey/pygmentsand the namespace name toRamsey\Pygments. Your copyright notices and the MIT license will remain intact. In theLICENSEfile, I will use something similar to this:I will do this only out of need to use this package within other projects and to continue its maintenance and development for others who wish to use it. If I hear from you, I'm more than happy to continue using and contributing to your upstream repository instead.
Thanks! 😄