add shutdown test cases #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not be merged in the current state but is rather supposed to show of a difference between Asio.SSL and WinTLS: Asio will produce a stream_truncated error on shutdown, if the remote did not properly shut down the protocol while WinTLS will not. Note https://stackoverflow.com/questions/25587403/boost-asio-ssl-async-shutdown-always-finishes-with-an-error Also, according to that post, Asio should produce an error if it initiated the shutdown and it goes through without problem. This does not seem to be the case (anymore?). This is only relevant for the https examples in WinTLS. Currently the https async example handles asio::error::eof (as do the beast examples), while the sync example does not.
Owner
|
Thanks for looking into this. I'll be happy to merge this once it's done. |
Contributor
Author
|
I close this in favor of #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged in the current state but is rather supposed to show of a difference between Asio.SSL and WinTLS: Asio will produce a stream_truncated error on shutdown, if the remote did not properly shut down the protocol while WinTLS will not.
Note https://stackoverflow.com/questions/25587403/boost-asio-ssl-async-shutdown-always-finishes-with-an-error
Also, according to that post, Asio should produce an error if it initiated the shutdown and it goes through without problem.
This does not seem to be the case (anymore?).
This is relevant for the https examples in WinTLS. Currently the https async example handles asio::error::eof (as do the beast examples async+sync), while the sync example does not.