Skip to content

Conversation

@remicollet
Copy link

PHP 7.4 compatibility

@remicollet
Copy link
Author

I'm aware this project is abandoned.
This is for legacy app (GLPI 9.4) while newer version (9.5) will use scssphp/scssphp

Copy link
Collaborator

@robocoder robocoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: see if this is applicable to https://github.com/scssphp/scssphp ...
Not applicable to scssphp/scssphp.

@LukeTowers
Copy link

Looks like it's semi applicable to scssphp/scssphp@66675c1 @robocoder, not sure if the other two changes are needed too

@mahagr
Copy link

mahagr commented May 1, 2020

FYI:

If someone really needs the old leafo/scssphp because of reasons, here is how you can do it:

PHP 7.4 fix:
https://github.com/gantry/gantry5/blob/develop/src/platforms/grav/classes/Leafo/ScssPhp/Compiler.php

You can then autoload the modified file from you composer:
https://github.com/gantry/gantry5/blob/develop/src/platforms/grav/composer.json#L23

@mediaclinic
Copy link

mediaclinic commented Dec 7, 2020

This PHP7.4 fix really helped to fix the problem with SCSS. Thanks @mahagr. Is this fix going to be part of the official package, @LukeTowers? Any change to merge this fix @leafo?

@mahagr
Copy link

mahagr commented Dec 8, 2020

The project has been abandoned because of the person who owns this repository hasn't been around for long time. So I see no hopes for fixing this issue. Just raise the minimum php requirement to 5.6 and use scssphp/scssphp instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants