[Bug] Fix buffer-overflow in SetThreadName
#1071
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By running msvc's ASan on this project, we detected a buffer-overflow error in
RaiseExceptioncall inCoreThreadWin'sSetThreadName.See the relevant bit below
This method follows the pattern outlined in these docs with one difference, it is dividing
sizeof(info)bysizeof(DWORD)instead ofsizeof(ULONG_PTR).This difference is fine for 32-bit architectures (1 pointer = 1 DWORD, or 4 bytes), but not for 64 bit, where 1 pointer is 2 DWORDS (8 bytes).
This PR aims to correct this minor arithmetic error, so it works across all architectures. Thanks!